Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-857]: Fixed Jira bot DMs you when you mention yourself in a comment #973

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 20, 2023

Summary

  • Fixed the issue of Jira bot DMs you when you mention yourself in a comment

Issue Link

Fixes #857

What to test

  • Jira bot sending you DM when you mention yourself in a comment

How to test

  • Install the plugin
  • Configure & setup the plugin
  • Create & connect the webhook
  • mention yourself in a comment on a Jira issue

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.63%. Comparing base (d2183a1) to head (66bf3a7).
Report is 76 commits behind head on master.

Files Patch % Lines
server/webhook_parser.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   29.65%   29.63%   -0.03%     
==========================================
  Files          52       52              
  Lines        7792     7792              
==========================================
- Hits         2311     2309       -2     
- Misses       5285     5287       +2     
  Partials      196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Sep 26, 2023
@mickmister
Copy link
Contributor

@Kshitij-Katiyar Does this work for Jira Cloud and Server? I'm thinking maybe this was just broken for Jira Cloud?

@mickmister
Copy link
Contributor

@Kshitij-Katiyar Does this need QA review or is this ready for merge?

@raghavaggarwal2308
Copy link
Contributor

@mickmister I think it would be better to get it tested by a QA before merging.

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While creating the build for this, I am facing some errors, please look into this @raghavaggarwal2308

@AayushChaudhary0001 AayushChaudhary0001 self-requested a review July 25, 2024 08:46
@AayushChaudhary0001 AayushChaudhary0001 added the Do Not Merge Should not be merged until this label is removed label Jul 25, 2024
@raghavaggarwal2308
Copy link
Contributor

@AayushChaudhary0001 The issue should be fixed now. Please verify.

@raghavaggarwal2308 raghavaggarwal2308 removed the Do Not Merge Should not be merged until this label is removed label Jul 29, 2024
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the following scenarios:-

  • No DM if the user mentions himself in the comment through jira bot.
  • DM received if any other user mentions him in the comment through jira bot.

The PR was working fine for the above scenarios, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 removed the 3: QA Review Requires review by a QA tester label Sep 9, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit 3f7e52b into mattermost:master Sep 9, 2024
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-857 branch September 9, 2024 16:56
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.2.0 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jira bot DMs you if you mention yourself in a comment on a Jira issue
6 participants