-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-857]: Fixed Jira bot DMs you when you mention yourself in a comment #973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #973 +/- ##
==========================================
- Coverage 29.65% 29.63% -0.03%
==========================================
Files 52 52
Lines 7792 7792
==========================================
- Hits 2311 2309 -2
- Misses 5285 5287 +2
Partials 196 196 ☔ View full report in Codecov by Sentry. |
@Kshitij-Katiyar Does this work for Jira Cloud and Server? I'm thinking maybe this was just broken for Jira Cloud? |
@Kshitij-Katiyar Does this need QA review or is this ready for merge? |
@mickmister I think it would be better to get it tested by a QA before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While creating the build for this, I am facing some errors, please look into this @raghavaggarwal2308
@AayushChaudhary0001 The issue should be fixed now. Please verify. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been tested for the following scenarios:-
- No DM if the user mentions himself in the comment through jira bot.
- DM received if any other user mentions him in the comment through jira bot.
The PR was working fine for the above scenarios, LGTM. Approved.
Summary
Issue Link
Fixes #857
What to test
How to test